microsoft / microsoft/krabsetw
Unhandled exception thrown by get_event_schema_from_tdh() in ut::forward_events()
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 801
- Forks
- 167
- Avg merge
- 3d 15m
- Merged PRs (30d)
- 2
Description
get_event_schema_from_tdh() can throw an exception in case an error is returned by TdhGetEventInformation(). This exception is not handled in ut::forward_events() and will result in process termination. This happens before user callbacks are called so there is no way of setting up exception handling by the user.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing ut::forward_events() into get_event_schema_from_tdh(), especially the TdhGetEventInformation() error path. Check how exceptions are currently propagated before user callbacks and identify existing tests or error-handling conventions in the repository. Done means an error there no longer terminates the process unexpectedly and the behavior is covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100