Colorama is not being installed in Windows even though it is required
Open
@jiasli is already working on this.
Since Mar 16, 2022.
- Dominant language
- Python
- Stars
- 358
- Forks
- 101
- PR merge metrics
- No merged PRs in 30d
Description
Since version 0.8.3 (which has been removed from public feeds) colorama is only added to the list of requirements if the setup.py is executed in a Windows machine. However, knack is being distributed as a wheel package and setup.py is not executed when installing a wheel package. Therefore, knack is broken when executed from a terminal.
conditional dependency needs to follow PEP 508.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.