_command_handler needs to be extensible
Open
Nobody has claimed this yet.
type/discussion
- Dominant language
- Python
- Stars
- 358
- Forks
- 101
- PR merge metrics
- No merged PRs in 30d
Description
In CLI 2.0 we expose the no_wait parameter in the _command_handler method of the create_command method in CLICommandsLoader. This method is not customizable, so I had to copy and modify the entire implementation from the base class.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in CLICommandsLoader and trace create_command to its _command_handler implementation. Review how no_wait is exposed and identify an extension point that avoids copying the base implementation. Done means callers can customize the handler while retaining the existing command behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100