microsoft / microsoft/kiota

formats mappings adjustments (breaking batch)

Open
#2,327 2 comments 0 reactions 0 assignees View on GitHub
generator type:bug
Dominant language
C#
Stars
3.8k
Forks
333
Avg merge
16h 29m
Merged PRs (30d)
116

Description

While [working on documenting the different format that can be used in OAS](https://github.com/OAI/OpenAPI-Specification/pull/3167) I realized Kiota was not mapping some formats properly:

- [ ] "decimal" should only be a child of string type as the serialization process will trim trailing zeros for numbers, loosing precision. => map string:decimal to a string (decimal type) on the wire, and number:decimal to a number (double) on the wire. (BREAKING)
- [ ] "base64" and "base64url" are different in their serialization and deserialization logic, and should ultimately map to stream. (BREAKING)
- [ ] should we add support for char? (BREAKING)
- [ ] type array with uniqueItems: true (items) should map to a hashset

Contributor guide

Open the contributing guide

Research direction

The issue names no files, tests, or entry points. Start by locating Kiota's format-mapping logic and related tests, then trace the listed decimal, base64, char, and uniqueItems cases through generation and serialization. Done means each agreed mapping is covered by tests, including the documented breaking behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, openapi
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.