microsoft / microsoft/kiota-python
Investigate whether the async credentials should be closed by this library or by the caller
Open
Nobody has claimed this yet.
dependencies
enhancement
- Dominant language
- Python
- Stars
- 31
- Forks
- 39
- Avg merge
- 11h 45m
- Merged PRs (30d)
- 42
Description
[Their documentation](https://learn.microsoft.com/en-us/python/api/azure-core/azure.core.credentials_async.asynctokencredential?view=azure-python) is terrible but I'm wondering what close does and whether we need to call it after each authentication request or when we don't need the credential object anymore? (wondering whether we'll have the same issue as the http package where it stops working after the first request)
Originally posted by @baywet in https://github.com/microsoft/kiota-authentication-azure-python/pull/45#discussion_r1037099637
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Azure's AsyncTokenCredential documentation linked in the issue and the discussion from microsoft/kiota-authentication-azure-python PR #45. Determine the intended ownership and lifecycle of close(); done should be a clear decision about whether the library or caller manages credential closure and reuse.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, python
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100