microsoft / microsoft/kiota-php
sendAsync promise return nulls upon creation
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 8
- Forks
- 10
- Avg merge
- 10h 16m
- Merged PRs (30d)
- 3
Description
When using the GuzzleRequestAdapter in the Microsoft Graph SDK, certain API calls (such as creating a team) return an empty result.
The problem is that the current implementation of sendAsync returns null for empty responses, even thought there may be important information in the headers.
So, in my opinioin, it should either return the raw response in those cases to allow us to read the headers when using the sdk, or either, attempt to build a valid response object from the response headers if the body is empty (at least, if the response code is 201 - Created).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at GuzzleRequestAdapter::sendAsync and trace how empty responses and response headers are handled. Clarify whether the expected result is the raw response or a response object for a 201 Created response, then add coverage for the empty-body case and verify that the relevant headers remain accessible.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100