microsoft / microsoft/just

Webpack task options should be split from webpack config overrides

Open
#175 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Feature
Dominant language
TypeScript
Stars
2k
Forks
97
PR merge metrics
No merged PRs in 30d

Description

The options to the webpack task achieve 2 things:

  1. Configures things for the actual just task (nodeArgs, path to config file)
  2. Passes generic overrides to the webpack config

This resulted in a bug that is addressed in #174, but we need a better long term solution, such as putting the config overrides under a configOverrides property on the task config

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the webpack task options and the webpack config handling described in this issue, along with the bug fix in #174. Separate task-specific settings such as nodeArgs and the config path from generic webpack configuration overrides under a configOverrides property. Done means the two option categories are distinct without reintroducing the bug addressed by #174.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, webpack
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.