microsoft / microsoft/jericho

games stuck at certain steps (location ids)

Open
#64 6 comments 0 reactions 1 assignee View on GitHub

@MarcCote is already working on this.

Since Jun 2, 2023.

bug
Dominant language
C
Stars
337
Forks
48
Avg merge
9h 5m
Merged PRs (30d)
2

Description

I have been using Jericho for some projects, trinity always gets stuck at these steps when calling env.get_valid_actions()

TRINITY_STUCK_STEPS = set(
    [8, 13, 23, 29, 33, 35, 39, 43, 47, 49, 58, 59, 60, 65, 68, 69]
)

Actually, later I found it's the location id that matters. Here are the ones for trinity and sherlock

TRINITY_STUCK_LOC_ID = (79, 354, 144, 355, 531, 179, 371, 121, 438, 576, 323, 319, 575, 80, 316)
SHERLOCK_STUCK_LOC_ID = (111, 3, 37, 33, 93, 71, 5, 73, 1, 85, 295, 52, 57, 21, 69, 27, 12)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.