microsoft / microsoft/jbpf

Remove JBPF_EXPERIMENTAL_FEATURES from header files

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
C
Stars
73
Forks
23
Avg merge
21h 17m
Merged PRs (30d)
1

Description

Due to the fact that JBPF_EXPERIMENTAL_FEATURE is used in Jbpf header files, and conditionally include fields in structures, all application code must also be built with this compile argument.

This is slightly messy.
Instead the JBPF_EXPERIMENTAL_FEATURE should be removed from header files and added to function bodies.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin by locating the JBPF header files that use JBPF_EXPERIMENTAL_FEATURES and reviewing the related function bodies. Move the conditional behavior out of headers so application code no longer needs the compile argument, then verify that the affected structures and functions still build correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.