microsoft / microsoft/jbpf

Revisit jbpf_register_codelet_hook and jbpf_remove_codelet_hook for consistency

Open
#20 0 comments 0 reactions 1 assignee View on GitHub

@xfoukas is already working on this.

Since Nov 28, 2024.

Dominant language
C
Stars
73
Forks
23
Avg merge
21h 17m
Merged PRs (30d)
1

Description

In jbpf_register_codelet_hook, we assume there won't be duplicate codelet loaded to the hook, and in jbpf_remove_codelet_hook we assume there might be more than one codelet to remove. This is inconsistent.

We should revisit this, either remove L160 or relax the assumption of L60.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.