microsoft / microsoft/java-debug
SetBreakpointsRequestHandler fails when supplied path is using forward slashes
@testforstephen is already working on this.
Since Feb 7, 2020.
- Dominant language
- Java
- Stars
- 409
- Forks
- 204
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 4
Description
Description
When a DAP (debug adapter protocol) client sends a setBreakpoints request with a path that contains forward slashes the breakpoint is not set.
The server also (wrongfully?) reports back that the command was executed successfully.
Observed behavior
The code runs without halting at the breakpoint.
Expected behavior
The program should halt at the breakpoint and send a breakpoint event to the DAP client.
Logging with forward slashes (Not working)
Sending:
{
"command": "setBreakpoints",
"arguments": {
"source": {
"name": "Hello.java",
"path": "c:/project/src/main/java/Hello.java"
},
"breakpoints": [
{
"line": 6
}
],
"sourceModified": false,
"lines": [
6
]
},
"type": "request",
"seq": 3
}
Received:
{
"type": "response",
"seq": 4,
"body": {
"breakpoints": [
{
"message": "",
"line": 6,
"verified": null,
"id": 1
}
]
},
"command": "setBreakpoints",
"request_seq": 3,
"success": true
}
Logging with backward slashes (Working)
Sending:
{
"command": "setBreakpoints",
"arguments": {
"source": {
"name": "Hello.java",
"path": "c:\project\src\main\java\Hello.java"
},
"breakpoints": [
{
"line": 6
}
],
"sourceModified": false,
"lines": [
6
]
},
"type": "request",
"seq": 3
}
Received:
{
"type": "response",
"seq": 4,
"body": {
"breakpoints": [
{
"message": "",
"line": 6,
"verified": true,
"id": 1
}
]
},
"command": "setBreakpoints",
"request_seq": 3,
"success": true
}
Suggestion
I think the "offending" code is here
This line behaves differently depending if forward or backward slashes have been used.
Maybe replace all forward slashes with backward slashes if we are on windows.
Could be implemented before/after the drive letter fix.
System
Windows 10
DAP Client: emacs with lsp-mode/dap-mode
DAP Server: jdtls (Eclipse language server)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.