microsoft / microsoft/inshellisense

Nerd Font glyphs not used (for top-level commands)

Open
#437 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
10.7k
Forks
256
Avg merge
1d 23h
Merged PRs (30d)
11

Description

Describe the bug
With a Nerd Font setup (#350), the glyphs are not actually used (on the top level command).

To Reproduce

  • Install a nerd font and setup your terminal to use it. (for me "FiraCode Nerd Font Mono" in Windows Terminal @ Windows 11)
  • set useNerdFont=true in ~/.config/inshellisense/rc.toml
  • start a new session (for me is -s pwsh or cmd)
    • ensure glyphs are actually rendered, e.g.
    Write-Host "`u{E702} git  `u{E7B0} docker  `u{E709} github  `u{ED0D} node"
    
    should look like:
    Image
  • type "git" or "node" or any ot the supported commands listed in suggestions.tx NerdFontIcons
  • result, no glyphs:
Image Image

Expected behavior
Glyphs should be shown (for top-level commands)

Environment

  • OS: Win 11
  • Output of is --version: 0.0.2
  • Nodejs Version: 26.5.1
  • Shell: pwsh, cmd
  • Shell Version: 7.6.4

Additional context
I did a quick lookup and found that runtime.ts runCommand() resolves hard coded icons for aliases and specs. This may or may not explain the issue.
Thus, I suppose suggestions.ts getIcon() may not be called on the top-level, so the main purpose of the glyphs is basically never achieved?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with useNerdFont=true in ~/.config/inshellisense/rc.toml and a PowerShell or cmd session, using the commands and glyph checks described above. Read runtime.ts runCommand() and suggestions.ts getIcon(), then compare them with the supported commands in suggestions.ts NerdFontIcons. Done means top-level commands such as git and node display their Nerd Font glyphs.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.