microsoft / microsoft/ifc

Follow up to `import std`

Open
#108 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
76
Forks
19
PR merge metrics
No merged PRs in 30d

Description

PR #104 was rejected because it was not the strategy to support both import std and #include at the same time.

I am wondering if a PR that did the following would be acceptable

#if !defined(IFC_DONT_INCLUDE_STANDARD_LIBRARY_HEADERS)
#include <vector>
#endif

No mention of import std anywhere.
This would allow users to define IFC_NO_STANDARD_LIBRARY_INCLUDE and use import std.

I am really concerned that waiting for all compilers, CMake and every other part of the ecosystem to be perfect is still a long way away.

Note the current work around I use is to create empty version of every standard library header like <vector>. Then I change my include path to include these rather than the real headers and then include IFC headers. This is obviously pretty ugly!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read PR #104 first, then locate the IFC headers that include standard library headers. Compare the proposed conditional include behavior with the existing workaround and verify that users can choose between standard header inclusion and import std without breaking the current #include workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.