microsoft / microsoft/hve-core
docs: update workflows.md accessibility-browser-smoke row for new contract-test step
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 301
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 92
Description
### Component
Documentation
### Bug Description
Commit 56c30bcb (#2934) added a `Run accessibility contract tests` step (`npm run test:a11y:contracts`) to the `accessibility-browser-smoke` job in `.github/workflows/pr-validation.yml`, running before the existing `Run accessibility browser smoke tests` step (`npm run ci:test:a11y:smoke`). The corresponding row in `docs/architecture/workflows.md` (Jobs table, `## PR Validation Pipeline` > `### Jobs`) still describes this job only as:
```
| accessibility-browser-smoke | Inline | Browser accessibility smoke test |
```
which no longer reflects that the job also runs the new runner contract test suite (`.github/skills/accessibility/accessibility/tests/runtime_a11y/runner/*.test.mjs`) via `test:a11y:contracts`.
### Expected Behavior
The `Validates` column for `accessibility-browser-smoke` in `docs/architecture/workflows.md` should mention both the accessibility runner contract tests and the browser smoke tests, matching the two `run` steps in the job.
### Steps to Reproduce
1. Compare `.github/workflows/pr-validation.yml` job `accessibility-browser-smoke` (two run steps: `npm run test:a11y:contracts`, `npm run ci:test:a11y:smoke`) against the single-purpose description in `docs/architecture/workflows.md`'s Jobs table.
### Additional Context
Related files:
* `.github/workflows/pr-validation.yml` (`accessibility-browser-smoke` job)
* `package.json` (`test:a11y:contracts` script)
* `docs/architecture/workflows.md` (`### Jobs` table)
> Generated by [Documentation Update Check](https://github.com/microsoft/hve-core/actions/runs/35385812933) · auto · 84.6 AIC · ⌖ 1.73 AIC · ⊞ 9.5K · [◷](https://github.com/search?q=repo%3Amicrosoft%2Fhve-core+is%3Aissue+%22gh-aw-workflow-call-id%3A+microsoft%2Fhve-core%2Fdoc-update-check%22&type=issues)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the accessibility-browser-smoke job in .github/workflows/pr-validation.yml with the Jobs table in docs/architecture/workflows.md, and check the test:a11y:contracts script in package.json. Update the Validates cell to mention both the accessibility runner contract tests and browser smoke tests, matching the two run steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, node.js
- Domain
- ci-cd, documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 92/100