microsoft / microsoft/hcsshim

calling PropertiesV2 as library consumer

Open
#2,370 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
694
Forks
304
Avg merge
1d 19h
Merged PRs (30d)
28

Description

The windows_exporter embeds Microsoft's hcsshim library to fetch container metrics.

Currently, only the legacy v1 call can be used by other programs, as they do not have access to the internal package. For example, in hcsshim, the relevant function is defined internally and not exposed for external use.

https://github.com/microsoft/hcsshim/blob/e5c83a121b980b1b85f4df0813cfba2d83572bac/container.go#L169-L170

However, there is no v2 function available that supports the new functionality.

The v1 legacy call has some limitations: If containerd is used, network statistics are no longer available, and Host/Job Containers are not exposed.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with container.go around lines 169-170 and trace the internal function referenced in the issue. Determine the public API needed for external consumers to call PropertiesV2 and review how the existing v1 call exposes container metrics. Done means a v2 entry point is available to library consumers and supports the functionality missing from the legacy call.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
operating-systems
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.