Switch to an vendor neutral logger interface or stdlib slog logging
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 694
- Forks
- 304
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 28
Description
hcsshim currently uses logrus to implement its own logging interface. This approach is counterintuitive when hcsshim is used as a library.
As a library consumer, I would prefer the ability to inject my own logging system. In my case, I am using log/slog from the standard library.
Adopting a stdlib logger as the standard might be a better idea, as other loggers can provide adapters for compatibility. For example, slog-zap demonstrates how such adapters can be implemented.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing hcsshim’s logging interface and its use of logrus. Compare the tradeoffs of a vendor-neutral injected logger with adopting log/slog, using slog-zap as an adapter example. Done means the chosen approach is defined and library consumers can provide their own logger without hcsshim coupling them to logrus.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100