microsoft / microsoft/go

Add `git go-patch apply` arg to filter out commit message commands

Open
#512 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Area-Patching
Dominant language
Go
Stars
431
Forks
44
Avg merge
21h 18m
Merged PRs (30d)
30

Description

Some patch/commit descriptions may start to have commands in them to persist some behavior when patches are turned into commits and back. For example, to make this work:

When submitting a patch to upstream as a CL, these should be removed. I think it would make sense to add an arg for git go-patch apply to do this automatically.

As of writing, I'm not sure if we have a situation where we'd use the filter: the only command we currently have in mind is making the FIPS patches start at a higher patch number.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the git go-patch apply command and determine how patch descriptions become commit messages. Define the apply argument and the command patterns it should remove, then verify that applying a patch with such commands produces a commit message without them.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, go
Domain
cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.