microsoft / microsoft/go

Resolve TODO about `GOLANG_FIPS` and `GOFIPS` environment variables

Open
#397 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
431
Forks
44
Avg merge
21h 18m
Merged PRs (30d)
30

Description

The code checks for GOFIPS and then GOLANG_FIPS to see if they specify FIPS mode:

https://github.com/microsoft/go/blob/ea9cc8ea52d0a83c36f55d5ffcfb179d55bbdf9d/patches/0003-Integrate-OpenSSL-crypto-module.patch#L374-L381

GOLANG_FIPS is used by Red Hat: https://developers.redhat.com/blog/2019/06/24/go-and-fips-140-2-on-red-hat-enterprise-linux#fips_140_2_validated_cryptography

But GOFIPS is more similar to the existing GO* variables like GOROOT, GOFLAGS, etc: https://github.com/microsoft/go/pull/382. No built-in env vars have GOLANG in the name.

Which of these variables should we keep? Or both?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the environment-variable check in patches/0003-Integrate-OpenSSL-crypto-module.patch at lines 374-381, then read the linked Red Hat guidance and the referenced pull request. Compare the naming conventions and existing usage of GOFIPS and GOLANG_FIPS; done means reaching and documenting a decision about whether to keep one or both.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cryptography, security
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.