microsoft / microsoft/go

crypto/internal/boring: error when reading system-wide fips mode is ignored

Open
#295 0 comments 1 reaction 1 assignee View on GitHub

@qmuntal is already working on this.

Since Dec 2, 2021.

fips
Dominant language
Go
Stars
431
Forks
44
Avg merge
21h 18m
Merged PRs (30d)
30

Description

We should take an informed decision about what to do with errors found while reading /proc/sys/crypto/fips_enabled.

I'm hesitant to panic if there is an error reading /proc/sys/crypto/fips_enabled as this code will be always executed when running Go binaries. If an app wants to be 100% sure that is running in FIPS mode it should use boring.Enabled() or GOLANG_FIPS=1.

See https://github.com/microsoft/go/pull/291#discussion_r760612129 for more context.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.