microsoft / microsoft/go-sqlcmd
accept_eula gets saved into sqlconfig file by viper automatically
Open
Nobody has claimed this yet.
bug
- Dominant language
- Go
- Stars
- 595
- Forks
- 91
- Avg merge
- 9h 35m
- Merged PRs (30d)
- 1
Description
Viper automatically reflects SET SQLCMD_ env vars into the sqlconfig file. So when a user SET SQLCMD_EULA, accept_eula is getting persisted into the sqlconfig file. I don't think it is being honored when sqlcmd create is actually run, so it is benign, but it shouldn't be there.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with SET SQLCMD_EULA and inspect how Viper maps environment variables into the sqlconfig file during the sqlcmd configuration flow. Done means accept_eula is no longer persisted in sqlconfig while the relevant SQLCMD_EULA behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100