microsoft / microsoft/go-sqlcmd
Use a Uri package to build SQL Connection strings
Open
Nobody has claimed this yet.
enhancement
housekeeping
sqlcmd switch
- Dominant language
- Go
- Stars
- 595
- Forks
- 91
- Avg merge
- 9h 35m
- Merged PRs (30d)
- 1
Description
Right now
sqlcmd config connection-strings
is using sprintf to build the connection strings. This probably doesn't do escaping correctly in all situations.
Rewrite this code to use a Uri build for each connection string, which will ensure all values are correctly escaped.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the implementation behind sqlcmd config connection-strings and trace how each connection string is currently assembled with sprintf. Replace that assembly with a Uri builder and verify that values are escaped correctly in all relevant connection strings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100