microsoft / microsoft/gctoolkit

AbstractJavaVirtualMachine.getCommandLine() is currently stubbed out, can't retrieve CLI parameters for Pre-Unified log.

Open
#336 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.3k
Forks
177
Avg merge
1d 11h
Merged PRs (30d)
3

Description

Describe the bug
The getCommandLine() method has been stubbed out with a TODO. See https://github.com/microsoft/gctoolkit/blob/1476fc128465991f2c531645c780d3ed7c865f2c/api/src/main/java/com/microsoft/gctoolkit/jvm/AbstractJavaVirtualMachine.java#L84

Expected behavior
Expected this method, or child override in PreUnifiedJavaVirtualMachine to return the command line string from a Pre-Unified log file.

Additional context
There is a pending issue for building the Command Line args for Unified logging here: https://github.com/microsoft/gctoolkit/issues/263 which states that retrieving the command line is supported for Pre-Unified log files. However, the AbstractJavaVirtualMachine.getCommandLine() method is not overridden in PreUnifiedJavaVirtualMachine so the Abstract method is used instead.

Not sure if this was stubbed out while waiting for issue 263 or an oversight.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in api/src/main/java/com/microsoft/gctoolkit/jvm/AbstractJavaVirtualMachine.java at getCommandLine(), then inspect PreUnifiedJavaVirtualMachine and the Pre-Unified log parsing path. Compare the expected behavior with issue #263, and verify that the command-line string is returned for a Pre-Unified log without changing the Unified logging work.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.