microsoft / microsoft/fluentui

[Bug]: NavDrawer shows divider above Footer when scrolled to the bottom

Open Beginner friendly
#36,331 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Nav Fluent UI react-components (v9) Good First Issue 🏆 Help Wanted ✨ Type: Bug :bug:
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Component

Nav (Preview)

Package version

9.74.1

React version

18.3.1

Environment
Happens in stackblitz as well
Current Behavior

When scrolling to the bottom of NavDrawer with NavDrawerFooter, the divider between NavDrawerBody and NavDrawerFooter is unexpectedly shown. This happens only sometimes, but is always reproducible on zoomed in browser. This is because the check for height in useDrawerBody.js is exact, but the actual values are not:

Image
Expected Behavior

The divider is always hidden when scrolled to the bottom.

Reproduction

https://stackblitz.com/edit/rfaoh314?file=src%2Fexample.tsx

Steps to reproduce
  1. Zoom in browser to 110+%
  2. Scroll to the bottom of Nav
  3. The divider is visible even when it shouldn't
Are you reporting an Accessibility issue?

None

Suggested severity

High - No workaround

Products/sites affected

No response

Are you willing to submit a PR to fix?

yes

Validations
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the NavDrawer implementation and locate the height check in useDrawerBody.js. Reproduce the issue using the linked StackBlitz example with the browser zoomed to 110% or higher, then verify that the divider remains hidden at the bottom of NavDrawer when NavDrawerFooter is present.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.