microsoft / microsoft/fluentui
TeachingPopoverCarousel unable to override pageCount
Open
Nobody has claimed this yet.
Component: TeachingPopover
Fluent UI react-components (v9)
Resolution: Soft Close
- Dominant language
- TypeScript
- Stars
- 20.3k
- Forks
- 2.9k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 46
Description
Nothing I put in the pageCount slot will change the rendering result
<TeachingPopoverCarousel
strings={{
next: 'Next',
previous: 'Previous',
initialStepText: 'Close',
finalStepText: 'Finish',
}}
pageCount={<span>My custom page count</span>}
>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the TeachingPopoverCarousel component and reproduce the provided JSX with a custom pageCount value. Trace how pageCount is rendered and verify whether the supplied content is ignored. Done means the custom page count appears in the carousel rendering while the existing strings continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100