microsoft / microsoft/fluentui

[Bug]: Memory leak in web-components when use innerHTML Update

Open
#30,643 9 comments 0 reactions 1 assignee View on GitHub

@chrisdholt is already working on this.

Since Feb 28, 2024.

Resolution: Soft Close web-components
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Library

Web Components (@fluentui/web-components)

System Info
cdn import 2.5.16
chorme-121.0.6167.187
Are you reporting Accessibility issue?

None

Reproduction

https://codesandbox.io/p/sandbox/bitter-snow-8wp4xl?file=%2Findex.html%3A24%2C10

Bug Description

Actual Behavior

use doc.innerHTML to update DOM ,so many Detached HTMLElement in memory

Expected Behavior

free Detached HTMLElement

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.