microsoft / microsoft/fluentui

[NeutralColor]: Add possibility to change all Neutral Color/Greys with createLightTheme/createDarkTheme

Open
#30,459 10 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Area: Theming Fluent UI react-components (v9) Package: theme Type: Feature
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Library

React Components / v9 (@fluentui/react-components)

Describe the feature that you would like added

Add possibility to change all Neutral Color/Greys with createLightTheme/createDarkTheme.

Actually, method createLightTheme/createDarkTheme do not provided any possibility to change Neutral colors (like Fluent UI8).

It's a problem if the brand color contains a colored grey + primary color.

The only current way i finded, is create a complete Fluent UI 8 theme (https://codepen.io/pen) and use createV9Theme from @fluentui/react-migration-v8-v9 package

It's not a good way.

Possible solution :

Pass a greys Ramp to method.

createLightTheme: (brand: BrandVariants, greys? : Greys) => Theme

PS : For me it'a bug, i have marked this as feature

Have you discussed this feature with our team

No response

Additional context

No response

Validations
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
Priority

Normal

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the createLightTheme and createDarkTheme entry points in @fluentui/react-components, then compare their neutral-color handling with the Fluent UI 8 theme and the createV9Theme migration path. Done means callers can provide an optional Greys ramp and have the light or dark theme use those neutral colors, with the behavior covered by the relevant theme tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.