microsoft / microsoft/fluentui

[Bug]: v8 ComboBox scrollSelectedToTop not respected in Callout

Open
#29,866 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Fluent UI react (v8) Resolution: Soft Close
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Library

React / v8 (@fluentui/react)

System Info
System:
    OS: macOS 13.6.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 182.20 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Chrome: 119.0.6045.123
    Safari: 17.1
Are you reporting Accessibility issue?

None

Reproduction

https://codesandbox.io/s/fluentui-v8-combobox-wmk32w?file=/src/App.js

Bug Description

Actual Behavior

The ComboBox does not scroll to the selected item when the callout is opened. The selected item remains in its original position, and the list must be manually scrolled by the user. Using the keyboard arrows to update the selected item also does not cause the selected item to be focused.

Expected Behavior

The ComboBox should scroll to the selected item in the callout menu when scrollSelectedToTop is set to true, similar to the Dropdown callout behaviour.

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodeSandbox at src/App.js to reproduce the v8 ComboBox behavior with scrollSelectedToTop enabled. Trace the ComboBox callout behavior and compare it with the Dropdown callout behavior; done means the selected item scrolls into view when the callout opens and when keyboard arrows change the selection.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.