microsoft / microsoft/fluentui

[Bug]: Upgrading to Tabster v4 makes v8 Dialog trap focus break when mixed with v9 Dialogs

Open
#28,982 11 comments 0 reactions 1 assignee View on GitHub

@bsunderhus is already working on this.

Since Sep 5, 2023.

Component: FocusTrapZone Fluent UI react-components (v9) Resolution: Soft Close tabster
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Library

React Components / v9 (@fluentui/react-components)

System Info
n/a
Are you reporting Accessibility issue?

None

Reproduction

Open sandbox
Note that input/button focus zone works as expected, and that v9 works as expected. Open v8 and note that focus does not stay inside the dialog when tabbing forward (it does going backwards).

Remove the v9 control from the page, and the v8 dialog works again.

https://codesandbox.io/s/v8-modals-rendered-with-v9-tabster-4-based-controls-ly6sj9

Bug Description

Before upgrading to Tabster 4, focus would stay trapped in v8 Dialogs

After upgrading to Tabster 4, focus escapes v8 Dialogs and moves to browser chrome, even though v8 dialogs don't use Tabster. This does not appear to affect regular FocusTrapZones (as demo'ed in sandbox)

Logs

No response

Requested priority

Blocking

Products/sites affected

loop

Are you willing to submit a PR to fix?

no

Validations
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.