microsoft / microsoft/fluentui

[Bug]: fluent-slider does not flip in RTL

Open
#28,914 6 comments 0 reactions 1 assignee View on GitHub

@chrisdholt is already working on this.

Since Aug 20, 2023.

Fluent UI WC (v3) Resolution: Soft Close web-components
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Library

Web Components (@fluentui/web-components)

System Info
@fluentui/web-components@3.0.0-alpha.29
Are you reporting Accessibility issue?

None

Reproduction

https://codesandbox.io/s/fuiwc-slider-rtl-z5ky59?file=/index.html

Bug Description

Render fluent-slider in RTL applied either to the slider element itself or to its parent:

<fluent-slider dir="rtl"></fluent-slider>

<!-- or -->

<div dir="rtl">
  <fluent-slider></fluent-slider>
</div>

Actual Behavior

✅ the value increases from right to left (the screenshot shows value 8/10)
🚨 keyboard navigation is not flipped - right arrow increases value
🚨 track is filled from left

image

Expected Behavior

  • right arrow decreases value
  • track is filled from right
Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.