microsoft / microsoft/fluentui
[Bug]: fluent-accordion Icons not visible in dark theme
Open
@chrisdholt is already working on this.
Since Jul 6, 2023.
Fluent UI WC (v3)
Resolution: Soft Close
web-components
- Dominant language
- TypeScript
- Stars
- 20.3k
- Forks
- 2.9k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 46
Description
Library
Web Components (@fluentui/web-components)
System Info
-
Are you reporting Accessibility issue?
no
Reproduction
Bug Description
Check fluent-accordion stories in dark theme: https://web-components.fluentui.dev/?path=/docs/components-accordion--accordion
Actual Behavior
Neither the default nor the custom expand/collapse icons are visible in the dark theme.
The svgs hardcode fill="#212121".
Light theme:
Dark theme 🚨:
Expected Behavior
The svgs use fill: currentColor, the icons are visible in all themes.
Logs
No response
Requested priority
Normal
Products/sites affected
No response
Are you willing to submit a PR to fix?
no
Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.