microsoft / microsoft/fluentui
[Bug]: slot cannot be passed a data-* attribute
Open
@bsunderhus is already working on this.
Since Mar 23, 2023.
Area: Typescript
Fluent UI react-components (v9)
Needs: Discussion
Package: utilities
Resolution: Soft Close
Status: Blocked
Status: In PR
- Dominant language
- TypeScript
- Stars
- 20.3k
- Forks
- 2.9k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 46
Description
Library
React Components / v9 (@fluentui/react-components)
System Info
N/A
Are you reporting Accessibility issue?
no
Reproduction
https://codesandbox.io/s/nice-poitras-wsk2c1?file=/example.tsx
Bug Description
Actual Behavior
Setting a "data-something" attribute to a slot results in TS error.
The data attribute is actually set on the appropriate DOM element.
Expected Behavior
Data attributes should be allowed in slot.
Logs
No response
Requested priority
High
Products/sites affected
No response
Are you willing to submit a PR to fix?
yes
Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.