microsoft / microsoft/fluentui

VirtualizerScrollView uses flex-direction for items

Open
#27,285 12 comments 1 reaction 1 assignee View on GitHub

@Mitch-At-Work is already working on this.

Since Mar 27, 2023.

Component: Virtualizer Fluent UI react-components (v9) Resolution: Soft Close
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Using flex-direction to change orientation of items is an a11y antipattern since screen readers and keyboard navigation libraries will always follow DOM order. The change was introduced in https://github.com/microsoft/fluentui/pull/26985.

The usage of flex-direction should be removed because of a11y trap that users can fall into

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.