microsoft / microsoft/fluentui

priority-overflow should be able to handle gaps and regular margins

Open
#23,066 7 comments 1 reaction 1 assignee View on GitHub

@ling1726 is already working on this.

Since May 18, 2022.

Fluent UI react-components (v9) Package: priority-overflow Partner Ask Resolution: Soft Close Status: In PR
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

Currently the overflow manager has a padding property to help account for space that is not a part of element content boxes (mainly margin).

However, in the case where regular margins are set on overflow items, or the container uses a gap, it would be useful to take that into account during available space calculation.

  • getComputedStyles to actually read the computed margin ?
  • some kind of regularPadding prop that applies to all overflow items equally
  • each item has a padding prop ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.