microsoft / microsoft/fluentui

typings: replace `custom-globals` with `static-types` in all projects if possible

Open
#20,544 20 comments 0 reactions 1 assignee View on GitHub

@Hotell is already working on this.

Since Nov 9, 2021.

Area: Build System Area: Typescript Resolution: Soft Close
Dominant language
TypeScript
Stars
20.3k
Forks
2.9k
Avg merge
2d 9h
Merged PRs (30d)
46

Description

We introduced new global typings for declaring static assets in typings/static-assets. Prior to this change, static asset extensions were mixed with typings/custom-globals which defines additional ECMA definitions for IE11 and legacy browsers.

As vNext packages are no longer supporting legacy browsers we need to get rid of all custom-globals in those packages ( this will be automated via migrate-converged-pkg generator ).

Actual behavior:

All/most packages use custom-globals global types

Expected behavior:

All projects use global types as needed:

  • vNext packages don't use those types at all
  • apps / additional projects need to be evaluated and changed manually
  • Once these 2 previous points are implemented we can get rid of hard dependency on static-assets within custom-globals
    • 2021-11-08 at 18 02

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.