microsoft / microsoft/fluentui
Menu: Update aria relationships if user manually sets `id` prop
Open
@ling1726 is already working on this.
Since May 25, 2021.
Component: Menu
Fluent UI react-components (v9)
Resolution: Soft Close
Status: In PR
- Dominant language
- TypeScript
- Stars
- 20.3k
- Forks
- 2.9k
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 46
Description
Currently aria-labelledby or aria-describedby relationships in Menu are automatic. The useId hook is used to generate ids. If a users uses their own id prop they must also set their own aria relationship with that id manually.
Expected result: If the user manually sets id prop then aria relationships that depend on it should update. This should not work in the reverse (updating aria prop manually)
Reference PR comment about this: (aria-labelledby, https://github.com/microsoft/fluentui/pull/17387#discussion_r595403952)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.