microsoft / microsoft/fluentui-react-native
Components: Generate Toolbar
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 179
- Avg merge
- 16h 17m
- Merged PRs (30d)
- 30
Description
Summary
Generate Toolbar with its canonical contract, implementation, tests, stories, platform validation, and explicit package export so related commands have a consistent keyboard-oriented container. Its child controls exist, but roving focus remains blocked on the shared FocusZone decision.
Observed. toolbar is entry toolbar in the canonical catalog and has no
implementation in packages/agentic/components. Upstream describes it as: Horizontal container grouping icon-only Buttons, ToggleButtons, and Dividers into a cohesive control strip, with size-dependent gap spacing and delegated interaction states.
Goal
Generate the toolbar component in
packages/agentic/components/src/components against the
canonical Fluent Flex spec, with the colocated coverage, stories, and platform
validation the package requires, and export it explicitly from
src/index.ts.
Stage
Stage 3 (production). Wave 3 - focus-orchestrated and composed.
Why it matters
Observed. The canonical catalog has 50 components and the agentic library has
generated 18. toolbar is one of the 32 in the gap, enumerated in
the missing-components index.
Inferred. It is a composed or focus-orchestrated component whose blockers resolve once the wave 2 overlay stack and the focus decision land, so it is a direct measure of whether those foundations were built correctly.
Observed current state
Canonical spec and source
| Field | Value |
|---|---|
| Canonical spec | plugins/components/skills/toolbar/SKILL.md with usage.md, web/tokens.yaml, web/accessibility.md, and web/interaction.md, at x3-design/fluent-design @ d334acf |
| Upstream tier | molecule |
| Upstream catalog key | toolbar in component-map.yaml |
| Local staged spec | packages/agentic/components/specs/toolbar - SPEC.md, usage.md, interaction.md, accessibility.md, tokens.yaml, blockers.md |
| Local implementation | None. No src/components/toolbar directory exists |
Closest existing FURN or V1 implementation
- No toolbar exists in any FURN catalog. The closest structural precedent is
packages/experimental/Overflowfor a horizontal strip with overflow handling, andpackages/components/Menu/src/MenuItem/useMenuItem.ts, which the blocker record cites as the canonical composite keyboard and focus example.
Note on platform canon. Where a legacy package has platform-specific files, the
desktop path (.win32, .windows, .macos, or the unsuffixed cross-platform file)
is the compatibility reference. .ios, .android, and .mobile variants are not
treated as the cross-platform canonical implementation.
Local dependencies
src/components/button- Observed present (component).src/components/divider- Observed present (component).src/primitives/icon- Observed present (primitive).
Known blockers
Observed (blockers.md, blocker class B in the index).
Three blockers were recorded: the spec requires roving tabindex, arrow-key movement, Home/End, and wrap-around focus, but "the current Button contract is a plain function component whose props are limited to ButtonProps and does not expose a ref/componentRef escape hatch for programmatic focus movement"; the package dependency surface is intentionally minimal and excludes the keyboard and focus helpers used by legacy composite widgets; and there was no local Divider to reuse.
Reassessment.
Partly stale. src/components/divider now exists. The focus escape hatch on button does not, and it is a real prerequisite. Inferred: unblocked by toggle-button plus a focus contract from focus-zone.md, and it requires adding a programmatic focus path to button.
Scope
- Ingest or promote the spec into the component directory in the generated shape
(SPEC.mdplus aspec/folder), per
spec-ingestion-and-generation.md. - Establish the public contract first: variants, slots, native props, accessibility,
interaction states, and platform behavior. - Implement the required file structure from
src/components/AGENTS.md:
toolbar.types.ts,toolbar.styles.ts,use*.ts,use*Styles.ts,render*.tsx, and
the assembly module with adisplayName. - Style from Flex tokens first and record genuine token gaps rather than substituting
unrelated values. - Export the component, its public types, and the state, style, and render stages
explicitly fromsrc/index.tsunder component-qualified unstable names. - Add the programmatic focus path the blocker identifies. This is a change to the existing
buttoncontract and should be raised as its own item if it grows. - Depends on
toggle-buttonfor the toggle members of the strip. - Implement one tab stop for the whole toolbar with arrow-key movement inside it.
Out of scope
- Changing the contract of an existing generated component, unless this task explicitly
calls for it above; raise it as its own item. - Building shared infrastructure owned by another task: overlay hosting
(popover), roving focus (focus-zone.md), spec
ingestion (spec-ingestion-and-generation.md),
or the coverage contract (component-test-strategy.md). - Migrating any legacy FURN consumer onto this component.
- Mobile platform support; the applicable upstream companion is
web, retargeted to
React Native for Windows and macOS.
Deliverables
src/components/toolbar/implementing the full required file structure.SPEC.mdand aspec/companion folder with provenance recording the upstream path,
SHA, and ingestion date.- Colocated
toolbar.test.tsx,toolbar.types.test.ts, andtoolbar.stories.tsx. - Snapshot coverage where the visual contract is state-dependent, or a recorded
exemption. - Explicit exports from
src/index.ts, withsrc/index.test.tsupdated. - A changeset, per the repository's version management rules.
- A recorded readiness level with its supporting evidence.
Required coverage, stories, and platform validation
Runtime and type coverage:
- Every size and its gap spacing.
- Buttons, toggle buttons, and dividers mixed in one strip, with dividers skipped by keyboard navigation.
- Arrow-key movement with wrap, plus Home and End.
- Exactly one tab stop for the whole toolbar.
- Toolbar role and the accessible names of icon-only children.
- Delegated interaction states are owned by the children, not the toolbar.
- User style and handler forwarding, and that user styles are applied after component
styles. - Compile-time slot acceptance and any mutually exclusive props.
Stories: a typed Meta titled Components/Toolbar, an args-driven Default, a
grouped Overview when the contract has several axes, one focused story per variant
axis, and an interactive story for each stateful axis. Self-driving axes expose
default<State> as the control; externally driven selection is owned by the story with
React.useState. Identity-changing axes are not exposed as controls.
Platform validation: the component's stories render and behave correctly on macOS
and on React Native Windows Fabric through apps/storybook,
including hover, pressed, disabled, focus, optional-slot, and constrained-content
scenarios. Add a stable root testID if the component joins the automated smoke set.
Acceptance criteria
-
src/components/toolbarexists with the required file structure and adisplayName. - Every variant axis in the component's
SPEC.mdis implemented, or a deviation is recorded in the spec. - The component styles from Flex tokens, with any genuine token gap recorded rather than approximated.
- Focus feedback renders through
FocusVisual; nooutline*props and no React Native Windows native focus visuals are introduced. - State precedence is explicit: disabled wins over pressed, which wins over hovered.
- Every stateful axis is classified as self-driving or externally driven, and both paths are covered.
- Runtime, type, and story coverage satisfy the package coverage contract.
- The component, its public types, and its pipeline stages are exported explicitly from
src/index.ts, andsrc/index.test.tscovers them. - The component's stories render on macOS and on React Native Windows Fabric.
-
yarn workspace @fluentui-react-native/components format,lint,build, andtestpass, and the Storybook bundle succeeds for both desktop platforms. - A readiness level is recorded with its supporting evidence.
- A changeset is included.
Dependencies and ordering
- Blocked by wave 2, either directly or through a wave 2 dependency listed above.
- Gated by component-test-strategy.md: the component must satisfy the coverage contract on arrival rather than being retrofitted.
- Gated by readiness-model.md: the target readiness level must be stated before the work starts.
- Consumes the Infrastructure workstream (
storybook-e2e.md) for automated macOS and Windows Fabric validation; until it lands, platform validation is manual.
Risks and open decisions
- Adding a focus escape hatch to
buttonwidens a public contract that 18 components' patterns are modeled on; the shape should be decided once and reused bytablist,radio-group, andnav. - Overflow behavior is not described upstream for Toolbar; decide explicitly whether it is in scope.
Evidence and references
- Upstream spec:
plugins/components/skills/toolbar/SKILL.mdand
components-index/SKILL.md
atx3-design/fluent-design@d334acf. - Local staged spec and blocker record:
packages/agentic/components/specs/toolbar. - Canonical implementations to follow:
src/components/button
for a styled higher-order component andsrc/primitives/icon
for a primitive. - Authoring rules:
src/components/AGENTS.mdand the
agentic component authoring skill. - Workstream context: Components README and
the missing-components index.
Sources retrieved 2026-08-20.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/agentic/components/specs/toolbar/SPEC.md and its spec files, then read src/components/AGENTS.md and inspect the existing button, divider, and index.ts entry points. Check the focus-zone and toggle-button dependencies before running the colocated tests and apps/storybook validation. Done means the required component files, coverage, stories, platform validation, exports, changeset, and readiness evidence are present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- accessibility, frontend, testing
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100