microsoft / microsoft/fluentui-react-native
Components: Generate Menu
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 179
- Avg merge
- 16h 17m
- Merged PRs (30d)
- 30
Description
Summary
Generate Menu with its canonical contract, implementation, tests, stories, platform validation, and explicit package export so action overlays are available in the agentic library. MenuItem and Divider now exist, while overlay positioning, light dismiss, focus return, roving focus, and type-ahead remain shared blockers.
Observed. menu is entry menu in the canonical catalog and has no
implementation in packages/agentic/components. Upstream describes it as: Composed overlay surface presenting a list of actions or options. Wraps a Popover instance and fills its content slot with MenuItem and Section Header children, inheriting container tokens from Popover and overriding only padding. Provides keyboard navigation, focus management, and ARIA menu context.
Goal
Generate the menu component in
packages/agentic/components/src/components against the
canonical Fluent Flex spec, with the colocated coverage, stories, and platform
validation the package requires, and export it explicitly from
src/index.ts.
Stage
Stage 2 (beta). Wave 2 - overlay and popover stack.
Why it matters
Observed. The canonical catalog has 50 components and the agentic library has
generated 18. menu is one of the 32 in the gap, enumerated in
the missing-components index.
Inferred. It belongs to the overlay stack, which is the largest single cluster of blocked components. Delivering the cluster converts a broad "not implementable" state into ordinary component work.
Observed current state
Canonical spec and source
| Field | Value |
|---|---|
| Canonical spec | plugins/components/skills/menu/SKILL.md with usage.md, web/tokens.yaml, web/accessibility.md, and web/interaction.md, at x3-design/fluent-design @ d334acf |
| Upstream tier | molecule |
| Upstream catalog key | menu in component-map.yaml |
| Local staged spec | packages/agentic/components/specs/menu - SPEC.md, usage.md, interaction.md, accessibility.md, tokens.yaml, blockers.md |
| Local implementation | None. No src/components/menu directory exists |
Closest existing FURN or V1 implementation
packages/components/Menu- The most complete legacy composition:Menu,MenuTrigger,MenuPopover,MenuList,MenuItem,MenuItemCheckbox,MenuItemRadio,MenuGroup,MenuGroupHeader,MenuDivider,MenuCallout, and a sharedcontext/.MenuListandMenuGrouprender FocusZone for keyboard navigation.
Note on platform canon. Where a legacy package has platform-specific files, the
desktop path (.win32, .windows, .macos, or the unsuffixed cross-platform file)
is the compatibility reference. .ios, .android, and .mobile variants are not
treated as the cross-platform canonical implementation.
Local dependencies
src/components/menu-item- Observed present (component).src/components/divider- Observed present (component).
Known blockers
Observed (blockers.md, blocker class B in the index).
Three blockers were recorded: the spec is explicitly a composition of Popover plus MenuItem and Divider children and "this package currently exports only Button and Icon"; the behavior requires a real overlay pipeline with light dismiss, trigger anchoring, submenu positioning, and focus return; and the accessibility contract depends on platform keyboard and focus behavior including roving focus and type-ahead.
Reassessment.
Partly stale. The first premise is out of date: src/components/menu-item and src/components/divider now exist. The overlay and focus blockers remain. Inferred: unblocked by popover plus the focus decision in focus-zone.md.
Scope
- Ingest or promote the spec into the component directory in the generated shape
(SPEC.mdplus aspec/folder), per
spec-ingestion-and-generation.md. - Establish the public contract first: variants, slots, native props, accessibility,
interaction states, and platform behavior. - Implement the required file structure from
src/components/AGENTS.md:
menu.types.ts,menu.styles.ts,use*.ts,use*Styles.ts,render*.tsx, and
the assembly module with adisplayName. - Style from Flex tokens first and record genuine token gaps rather than substituting
unrelated values. - Export the component, its public types, and the state, style, and render stages
explicitly fromsrc/index.tsunder component-qualified unstable names. - Compose the overlay host from
popoverand inherit its container tokens, overriding only padding as upstream specifies. - Decide the keyboard model against the outcome of focus-zone.md: roving focus, Home/End, type-ahead, and submenu open and close.
- Decide whether submenus are in scope for the first version.
Out of scope
- Changing the contract of an existing generated component, unless this task explicitly
calls for it above; raise it as its own item. - Building shared infrastructure owned by another task: overlay hosting
(popover), roving focus (focus-zone.md), spec
ingestion (spec-ingestion-and-generation.md),
or the coverage contract (component-test-strategy.md). - Migrating any legacy FURN consumer onto this component.
- Mobile platform support; the applicable upstream companion is
web, retargeted to
React Native for Windows and macOS.
Deliverables
src/components/menu/implementing the full required file structure.SPEC.mdand aspec/companion folder with provenance recording the upstream path,
SHA, and ingestion date.- Colocated
menu.test.tsx,menu.types.test.ts, andmenu.stories.tsx. - Snapshot coverage where the visual contract is state-dependent, or a recorded
exemption. - Explicit exports from
src/index.ts, withsrc/index.test.tsupdated. - A changeset, per the repository's version management rules.
- A recorded readiness level with its supporting evidence.
Required coverage, stories, and platform validation
Runtime and type coverage:
- Trigger opens and closes the menu, and the trigger's accessibility state reflects it.
- Arrow-key navigation, Home/End, and wrap behavior across MenuItem children.
- Section headers are not focusable.
- Escape and outside press dismiss, and focus returns to the trigger.
- Menu and menu-item roles and the accessible name of the menu.
- User style and handler forwarding, and that user styles are applied after component
styles. - Compile-time slot acceptance and any mutually exclusive props.
Stories: a typed Meta titled Components/Menu, an args-driven Default, a
grouped Overview when the contract has several axes, one focused story per variant
axis, and an interactive story for each stateful axis. Self-driving axes expose
default<State> as the control; externally driven selection is owned by the story with
React.useState. Identity-changing axes are not exposed as controls.
Platform validation: the component's stories render and behave correctly on macOS
and on React Native Windows Fabric through apps/storybook,
including hover, pressed, disabled, focus, optional-slot, and constrained-content
scenarios. Add a stable root testID if the component joins the automated smoke set.
Acceptance criteria
-
src/components/menuexists with the required file structure and adisplayName. - Every variant axis in the component's
SPEC.mdis implemented, or a deviation is recorded in the spec. - The component styles from Flex tokens, with any genuine token gap recorded rather than approximated.
- Focus feedback renders through
FocusVisual; nooutline*props and no React Native Windows native focus visuals are introduced. - State precedence is explicit: disabled wins over pressed, which wins over hovered.
- Every stateful axis is classified as self-driving or externally driven, and both paths are covered.
- Runtime, type, and story coverage satisfy the package coverage contract.
- The component, its public types, and its pipeline stages are exported explicitly from
src/index.ts, andsrc/index.test.tscovers them. - The component's stories render on macOS and on React Native Windows Fabric.
-
yarn workspace @fluentui-react-native/components format,lint,build, andtestpass, and the Storybook bundle succeeds for both desktop platforms. - A readiness level is recorded with its supporting evidence.
- A changeset is included.
Dependencies and ordering
- Blocked by
popoverfor the overlay host, anchoring, light dismiss, and focus return. - Gated by component-test-strategy.md: the component must satisfy the coverage contract on arrival rather than being retrofitted.
- Gated by readiness-model.md: the target readiness level must be stated before the work starts.
- Consumes the Infrastructure workstream (
storybook-e2e.md) for automated macOS and Windows Fabric validation; until it lands, platform validation is manual.
Risks and open decisions
- Type-ahead is described upstream but is a significant behavior with no React Native precedent in this repository; scope it explicitly in or out.
- Submenu positioning multiplies the anchoring complexity that
popovermust already handle.
Evidence and references
- Upstream spec:
plugins/components/skills/menu/SKILL.mdand
components-index/SKILL.md
atx3-design/fluent-design@d334acf. - Local staged spec and blocker record:
packages/agentic/components/specs/menu. - Canonical implementations to follow:
src/components/button
for a styled higher-order component andsrc/primitives/icon
for a primitive. - Authoring rules:
src/components/AGENTS.mdand the
agentic component authoring skill. - Workstream context: Components README and
the missing-components index.
Sources retrieved 2026-08-20.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/agentic/components/specs/menu/SPEC.md and its spec files, then read src/components/AGENTS.md and the existing menu-item and divider implementations. Check the popover and focus-zone dependencies before choosing the menu behavior; done requires the full src/components/menu structure, colocated tests and stories, platform validation, explicit index.ts exports, a changeset, and readiness evidence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100