microsoft / microsoft/fluentui-react-native
Components: Generate Combobox
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 179
- Avg merge
- 16h 17m
- Merged PRs (30d)
- 30
Description
Summary
Generate Combobox with its canonical contract, implementation, tests, stories, platform validation, and explicit package export so editable selection is represented in the agentic catalog. The local spec is still missing, and implementation also depends on the shared Popover and virtual-focus model.
Observed. combobox is entry combobox in the canonical catalog and has no
implementation in packages/agentic/components. Upstream describes it as: Composed selection control pairing an editable Input-styled text field with an overlay Popover containing a filterable list of options. Forwards Input's Style and Size axes and exposes Selection mode (Single/Multiple), Freeform (Filtering/Freeform), Clearable, and Open. Uses the editable-combobox pattern with a listbox popup, option rows, and virtual focus.
Goal
Generate the combobox component in
packages/agentic/components/src/components against the
canonical Fluent Flex spec, with the colocated coverage, stories, and platform
validation the package requires, and export it explicitly from
src/index.ts.
Stage
Stage 2 (beta). Wave 2 - overlay and popover stack.
Why it matters
Observed. The canonical catalog has 50 components and the agentic library has
generated 18. combobox is one of the 32 in the gap, enumerated in
the missing-components index.
Inferred. It belongs to the overlay stack, which is the largest single cluster of blocked components. Delivering the cluster converts a broad "not implementable" state into ordinary component work.
Observed current state
Canonical spec and source
| Field | Value |
|---|---|
| Canonical spec | plugins/components/skills/combobox/SKILL.md with usage.md, web/tokens.yaml, web/accessibility.md, and web/interaction.md, at x3-design/fluent-design @ d334acf |
| Upstream tier | molecule |
| Upstream catalog key | combobox in component-map.yaml |
| Local staged spec | None. No specs/combobox folder exists; the spec must be ingested first |
| Local implementation | None. No src/components/combobox directory exists |
Closest existing FURN or V1 implementation
packages/experimental/Dropdown-Dropdown/,Listbox/, andOption/- the nearest legacy equivalent, though it is not editable. No platform-specific files, so it is the cross-platform and desktop reference.
Note on platform canon. Where a legacy package has platform-specific files, the
desktop path (.win32, .windows, .macos, or the unsuffixed cross-platform file)
is the compatibility reference. .ios, .android, and .mobile variants are not
treated as the cross-platform canonical implementation.
Local dependencies
src/components/input- Observed present (component).src/components/listbox-item- Observed present (component).
Known blockers
Observed. There is no recorded blocker, because there is no local spec folder and therefore no
blockers.md. The absence of an ingested spec is itself the first blocker; see
spec-ingestion-and-generation.md.
Scope
- Ingest or promote the spec into the component directory in the generated shape
(SPEC.mdplus aspec/folder), per
spec-ingestion-and-generation.md. - Establish the public contract first: variants, slots, native props, accessibility,
interaction states, and platform behavior. - Implement the required file structure from
src/components/AGENTS.md:
combobox.types.ts,combobox.styles.ts,use*.ts,use*Styles.ts,render*.tsx, and
the assembly module with adisplayName. - Style from Flex tokens first and record genuine token gaps rather than substituting
unrelated values. - Export the component, its public types, and the state, style, and render stages
explicitly fromsrc/index.tsunder component-qualified unstable names. - Build on whatever shared internals
dropdownestablishes; the two differ mainly in editability and filtering. - Define the filtering contract: caller-supplied filtered options, or an internal filter over a supplied list.
- Implement the Freeform axis, where an arbitrary typed value is committable.
Out of scope
- Changing the contract of an existing generated component, unless this task explicitly
calls for it above; raise it as its own item. - Building shared infrastructure owned by another task: overlay hosting
(popover), roving focus (focus-zone.md), spec
ingestion (spec-ingestion-and-generation.md),
or the coverage contract (component-test-strategy.md). - Migrating any legacy FURN consumer onto this component.
- Mobile platform support; the applicable upstream companion is
web, retargeted to
React Native for Windows and macOS.
Deliverables
src/components/combobox/implementing the full required file structure.SPEC.mdand aspec/companion folder with provenance recording the upstream path,
SHA, and ingestion date.- Colocated
combobox.test.tsx,combobox.types.test.ts, andcombobox.stories.tsx. - Snapshot coverage where the visual contract is state-dependent, or a recorded
exemption. - Explicit exports from
src/index.ts, withsrc/index.test.tsupdated. - A changeset, per the repository's version management rules.
- A recorded readiness level with its supporting evidence.
Required coverage, stories, and platform validation
Runtime and type coverage:
- Both selection modes, both Freeform values, Clearable on and off.
- Typing filters the option list and keeps real focus in the field.
- Keyboard: move the active option, commit, clear, and dismiss.
- Editable combobox role and state in the accessibility tree.
- Both Input styles across all three sizes.
- User style and handler forwarding, and that user styles are applied after component
styles. - Compile-time slot acceptance and any mutually exclusive props.
Stories: a typed Meta titled Components/Combobox, an args-driven Default, a
grouped Overview when the contract has several axes, one focused story per variant
axis, and an interactive story for each stateful axis. Self-driving axes expose
default<State> as the control; externally driven selection is owned by the story with
React.useState. Identity-changing axes are not exposed as controls.
Platform validation: the component's stories render and behave correctly on macOS
and on React Native Windows Fabric through apps/storybook,
including hover, pressed, disabled, focus, optional-slot, and constrained-content
scenarios. Add a stable root testID if the component joins the automated smoke set.
Acceptance criteria
-
src/components/comboboxexists with the required file structure and adisplayName. - Every variant axis in the component's
SPEC.mdis implemented, or a deviation is recorded in the spec. - The component styles from Flex tokens, with any genuine token gap recorded rather than approximated.
- Focus feedback renders through
FocusVisual; nooutline*props and no React Native Windows native focus visuals are introduced. - State precedence is explicit: disabled wins over pressed, which wins over hovered.
- Every stateful axis is classified as self-driving or externally driven, and both paths are covered.
- Runtime, type, and story coverage satisfy the package coverage contract.
- The component, its public types, and its pipeline stages are exported explicitly from
src/index.ts, andsrc/index.test.tscovers them. - The component's stories render on macOS and on React Native Windows Fabric.
-
yarn workspace @fluentui-react-native/components format,lint,build, andtestpass, and the Storybook bundle succeeds for both desktop platforms. - A readiness level is recorded with its supporting evidence.
- A changeset is included.
Dependencies and ordering
- Blocked by spec-ingestion-and-generation.md: the spec must be pulled from the pinned upstream revision before generation can start.
- Blocked by
popoverfor the overlay host, anchoring, light dismiss, and focus return. - Gated by component-test-strategy.md: the component must satisfy the coverage contract on arrival rather than being retrofitted.
- Gated by readiness-model.md: the target readiness level must be stated before the work starts.
- Consumes the Infrastructure workstream (
storybook-e2e.md) for automated macOS and Windows Fabric validation; until it lands, platform validation is manual.
Risks and open decisions
- Text input plus an anchored overlay is the hardest keyboard case in the catalog; it needs on-device validation on macOS and Windows Fabric rather than Jest alone.
- Building this before the shared internals from
dropdownsettle would duplicate the trigger, surface, and row-selection logic.
Evidence and references
- Upstream spec:
plugins/components/skills/combobox/SKILL.mdand
components-index/SKILL.md
atx3-design/fluent-design@d334acf. - Canonical implementations to follow:
src/components/button
for a styled higher-order component andsrc/primitives/icon
for a primitive. - Authoring rules:
src/components/AGENTS.mdand the
agentic component authoring skill. - Workstream context: Components README and
the missing-components index.
Sources retrieved 2026-08-20.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the pinned upstream combobox spec, spec-ingestion-and-generation.md, and src/components/AGENTS.md, then compare packages/experimental/Dropdown and the existing input and listbox-item components. Review the dependency issues for popover and focus infrastructure before implementing. Done means the required component, spec, tests, stories, exports, platform validation, changeset, and workspace checks all pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- desktop, frontend, testing-qa
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100