microsoft / microsoft/fluentui-apple
Fluent floating button style bugs
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 977
- Forks
- 180
- Avg merge
- 21h 38m
- Merged PRs (30d)
- 1
Description
Environment Information
- Platform:
- iOS
- macOS
Please provide a reproduction of the bug:
The FluentButtonStyle(style: .floatingSubtle) style from the fluent library has some UI bugs.
Actual behavior:
The icon in the Floating fluent button style is not centered because of some padding added to the icon. Icon must be centered. The fluent icon shape is an oval, but it must be a circle. This is the expected UI design: https://www.figma.com/design/OLIFtMJnKfD4FGcnNq9TVo/Fluent-2-iOS?node-id=54882-225133&t=UMzRDU5cGJ4wAVxL-4
Expected behavior:
Icon must be centered, and button frame should be a circle.
Priorities and help requested:
Are you willing to submit a PR to fix? Yes, I am waiting for the expected design so that I can make the right updates.
Requested priority: Blocking
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the FluentButtonStyle(style: .floatingSubtle) entry point in the fluent library and inspect how the floating button lays out its icon and frame. Compare the implementation with the linked Fluent 2 iOS design, then verify that the icon is centered and the button frame is circular on iOS.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- design, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100