microsoft / microsoft/finops-toolkit
Update Key Vault to Support RBAC Permissions and Delete Protection
- Dominant language
- PowerShell
- Stars
- 603
- Forks
- 249
- Avg merge
- 7d 11h
- Merged PRs (30d)
- 11
Description
⚠️ Problem
For organizations that utilize the Enterprise Scale in association with the Cloud Adoption Framework (CAF), there are various Azure Policies and Initiatives that are deployed.
One of those Initiatives is the Enforce recommended guardrails for Azure Key Vault. This initiative contains several policies, including:
- Azure Key Vault should use RBAC permission model
- Key vaults should have deletion protection enabled
The current deployment of the FinOps Toolkit (Hub architecture), violates those 2 policies and prevents its deployment. We have to add/create an exception in the target Subscription / Resource Group, for the deployment to complete successfully.
🛠️ Solution
Update the FinOps Toolkit's Key Vault implementation to support the RBAC permissions model, and also enable delete protection.
ℹ️ Additional context
The client I am currently assisting, is in a regulated industry, and uses the CAF / Enterprise Scale Terraform modules.
🙋♀️ Ask for the community
We could use your help:
- Please vote this issue up (👍) to prioritize it.
- Leave comments to help us solidify the vision.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The Azure Key Vault implementation in the FinOps Toolkit Hub architecture is the entry point; no file or test is named. Review open pull request #2249 first, then locate the Key Vault resource and its existing coverage. Done means RBAC permissions and delete protection are supported without requiring policy exceptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, terraform
- Domain
- cloud, infrastructure, security
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100