microsoft / microsoft/fhir-server
AadSmartOnFhirProxyController.cs logs a caught null redirect URL as a NullRef exception
Nobody has claimed this yet.
- Dominant language
- TSQL
- Stars
- 1.4k
- Forks
- 592
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 41
Description
**Describe the bug**
AadSmartOnFhirProxyController.cs logs a caught null redirect URL as a NullRef exception
**To Reproduce**
If an empty redirect URL is passed to the AadSmartOnFhirProxyController.cs, the exception is caught appropriately, but still logged as a NullRef exception which appears in our exception list. This should be downgraded to informational or debug level.
**Expected behavior**
A less severe log should be created, such as debug or information level.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in AadSmartOnFhirProxyController.cs and trace the empty redirect URL path through its exception handling and logging. Check the controller's existing tests or logging conventions before making a change. Done means the expected caught condition no longer appears as a NullRef exception and is logged at an informational or debug level.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100