Max rounds is currently hardcoded so argument doesn't apply
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6.2k
- Forks
- 603
- PR merge metrics
- No merged PRs in 30d
Description
When setting max_rounds in an evaluation command, it's not actually used because 100 is hardcoded here:
https://github.com/microsoft/fara/blob/0aa8a48430c9a58f4b34fe7590ca1b14d487e5ec/webeval/src/webeval/systems/websurfer.py#L196
Need to change 100 -> self.max_rounds
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open webeval/src/webeval/systems/websurfer.py around line 196 and trace how max_rounds is stored and used by the evaluation command. Verify the command's configured value reaches the round limit, then run the relevant evaluation or existing checks to confirm the hardcoded limit is no longer used.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ai
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100