WatchBuilder.create() doesn't reject an error when erred
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 546
- Forks
- 76
- Avg merge
- 22h 46m
- Merged PRs (30d)
- 13
Description
When watcher can't connect to etcd server with some reason. I can't catch the error. I checked the code in watch.js and found there omit an event to listen in WatchBuilder.create(). The event is "disconnected".
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read watch.js and WatchBuilder.create(), then trace how the watcher handles connection failures. Done means a failed connection to the etcd server exposes the “disconnected” event so callers can catch the error; no test file is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- grpc, node.js, typescript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100