microsoft / microsoft/edit

Ctrl+P or mouse click outside the file switcher dialog should close it

Open
#228 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-task
Dominant language
Rust
Stars
14.6k
Forks
734
Avg merge
8h 40m
Merged PRs (30d)
4

Description

Right now once you summon the file switcher dialog the only way to close it is to re select the current file (click or with Enter) or the Esc key. If the menu was opened with the mouse a user may want to back out of the dialog by clicking outside of the boundaries of the window, or a keyboard user want to close the dialog with the same key shortcut that summoned it.

Right now it can feel like you've become trapped it the dialog or have to pick a file again unless you make a change to a different use pattern to press Esc to close without making a new selection

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the file switcher dialog and its mouse and keyboard event handling. Check how Ctrl+P, Enter, and Esc currently affect the dialog, then verify that clicking outside it or pressing Ctrl+P again closes it without selecting a different file.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.