microsoft / microsoft/edge-ai

ci(security): SHA-pin slsa-framework/slsa-github-generator in pages-deploy.yml

Open
#263 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement security
Dominant language
HCL
Stars
104
Forks
48
Avg merge
2d 8h
Merged PRs (30d)
24

Description

Problem

The slsa-framework/slsa-github-generator reusable workflow in pages-deploy.yml (line ~782) is referenced by tag only:

uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@v2.1.0

While #100 will replace this entirely with actions/attest@v4.1.0, the tag-only reference is a supply chain risk in the interim. Tag references are mutable — a compromised tag could inject malicious code into the attestation workflow.

Proposed Solution

SHA-pin the existing reference until #100 lands:

uses: slsa-framework/slsa-github-generator/.github/workflows/generator_generic_slsa3.yml@bcb39c1a0aa1e68c09f445acae2ca1116e301104  # v2.1.0
Acceptance Criteria
  • slsa-framework/slsa-github-generator@v2.1.0 SHA-pinned with version comment
  • SHA verified against slsa-framework/slsa-github-generator v2.1.0 release tag
  • No behavioral change — same workflow, immutable reference
Notes

This is an interim fix. Issue #100 will remove this reference entirely. If #100 is implemented first, this issue can be closed as superseded.

Dependencies
  • Superseded by: #100 (will remove this reference entirely)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open pages-deploy.yml around line 782 and inspect the reusable slsa-github-generator workflow reference. Verify the proposed SHA against the v2.1.0 release tag, then confirm the workflow remains otherwise unchanged and check whether issue #100 has already removed the reference.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.