microsoft / microsoft/ebpf-for-windows

Complete multi-attach support for Accept

Open
#5,571 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
C
Stars
3.6k
Forks
311
Avg merge
6d 10h
Merged PRs (30d)
21

Description

### Describe the feature you'd like supported

Only connect and bind have multi-attach support:
https://github.com/microsoft/ebpf-for-windows/blob/2977cce5be13ac5ad05a4e3a25f93c29a3743765/netebpfext/net_ebpf_ext_sock_addr.c#L1477-L1490

this was closed when the new bind hook was implemented with multi-attach support: https://github.com/microsoft/ebpf-for-windows/issues/5180

listen support is tracked here: https://github.com/microsoft/ebpf-for-windows/issues/5339

we also need accept support.

### Proposed solution

Complete multi-attach support for accept, add tests

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the multi-attach implementation for connect and bind in netebpfext/net_ebpf_ext_sock_addr.c, especially the referenced section, then locate the corresponding accept path and existing tests. Compare the tracked listen work in issue #5339 as needed. Done means accept supports multi-attach and the added tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
networking
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.