microsoft / microsoft/ebpf-for-windows

Cleanup: catch2 now allows multiple threads

Open
#4,553 1 comment 0 reactions 2 assignees Claimed by @nmlud21 View on GitHub
cleanup good first issue P3 triaged
Dominant language
C
Stars
3.6k
Forks
311
Avg merge
6d 10h
Merged PRs (30d)
21

Description

### Describe the bug

I previously filed Issue #4079 which Anurag fixed in PR #4155 back when catch2 changed to not allow multiple threads.
At that time, I filed https://github.com/catchorg/Catch2/issues/2935 against catch2 due to this regression.
That issue was just fixed via an opt-in macro.

So we can finally clean up our code again by revisting/reverting 4155 and cleaning up any subsequently added workarounds.

### OS information

_No response_

### Steps taken to reproduce bug

Code inspection.

### Expected behavior

Go back to cleaner implementation approach.

### Actual outcome

Currently have workarounds in place.

### Additional details

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.