microsoft / microsoft/ebpf-for-windows
Clean up libs\thunk\mock\mock.cpp _stop_service
- Dominant language
- C
- Stars
- 3.6k
- Forks
- 311
- Avg merge
- 6d 10h
- Merged PRs (30d)
- 21
Description
### Describe the bug
https://github.com/microsoft/ebpf-for-windows/blob/main/libs/thunk/mock/mock.cpp#L185 says:
```
// TODO: (Issue# 852) Just a stub currently in order to compile.
// Will be replaced by a proper mock.
```
However issue #852 is closed as fixed. We could reopen that bug, but I decided to create a new one instead.
### OS information
_No response_
### Steps taken to reproduce bug
Code inspection.
### Expected behavior
Code should not reference a fixed bug as a TODO
### Actual outcome
Code references a fixed bug as a TODO
### Additional details
_No response_
Contributor guide
Research direction
Review libs/thunk/mock/mock.cpp around line 185, where _stop_service contains the TODO referencing issue #852. Confirm that issue #852 is closed, then update the stale comment so it no longer references a fixed issue. Done means the code no longer presents issue #852 as an active TODO; no specific test is mentioned.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100