microsoft / microsoft/ebpf-for-windows
Fix error handling and error reporting issues in the 'peparse' library.
- Dominant language
- C
- Stars
- 3.6k
- Forks
- 311
- Avg merge
- 6d 10h
- Merged PRs (30d)
- 21
Description
### Describe the bug
Observed issues:
1. Calls return `null` pointers on errors as expected but fail to set the error code in certain error handling paths.
2. Calls do not return windows specific error codes when using windows API calls.
Note: This is a third-party module and the fixes need to be pushed upstream as well.
### OS information
_No response_
### Steps taken to reproduce bug
N/A
### Expected behavior
N/A
### Actual outcome
N/A
### Additional details
_No response_
Contributor guide
Research direction
Start by locating the vendored or referenced peparse library and trace its error paths, especially calls that return null pointers and calls wrapping Windows APIs. Reproduce the reported cases if possible, then verify that every failure sets an error code and that Windows API failures preserve Windows-specific codes. The fixes also need to be prepared for upstream submission.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems, reverse-engineering
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100