microsoft / microsoft/durabletask-mssql
CodeQL: Usage of Newtonsoft.Json.TypeNameHandling.All considered unsafe
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 105
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
This is a CodeQL issue. CodeQL tracking item can be found here.
More information on how to fix the issue here.
We can't simply use TypeNameHandling.None because that would be a breaking change, preventing exceptions from being deserialized. However, there are other workarounds that can be considered, as noted in the above informational link.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CodeQL tracking item and the linked CodeQL.SM02211 guidance, then locate the repository's use of Newtonsoft.Json.TypeNameHandling.All. Determine a workaround that removes the unsafe CodeQL finding without preventing exceptions from being deserialized; done means the warning is addressed and the existing compatibility constraint is preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100